On Wed, 13 Aug 2025 14:24:28 GMT, Manuel Hässig <mhaes...@openjdk.org> wrote:
> > I would suggest to drop: `"jdk.advanced.disable.nbjavac": true,` > > Can you elaborate on the surprising results? When developing the JDK we will > most probably use features not supported by the `nbjavac`. In general, it can be anything. From relatively minor problems like not working code completion in some corner case, to a complete failure of the Java editor features. When nbjavac is disabled, the javac in the JDK on which the extension runs needs to be "close enough" to the version of javac on which nbjavac is based (I believe it is currently ~JDK 24). And depending on the differences between the version against which the extension is built and the real javac in JDK, the there may be unobservable, minor or major negative effects. If the runtime JDK is too old, there's a warning. But if it is newer, then it is expected the user knows what they are doing. And I am not sure if everyone using this task will know how to interpret potential failures, given they didn't knowingly select the option. (It is true that JDK 24 and JDK 25 seem to be close enough, so that there are no major effects, and maybe not even minor effects. That may or may not be the case with any upcoming JDK 26 version.) ------------- PR Comment: https://git.openjdk.org/jdk/pull/26759#issuecomment-3188868986
