On Fri, 22 Aug 2025 22:18:46 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> Please review this change to use C++17 for building C++ parts of the JDK. In >> particular this affects HotSpot. This change also includes an update to the >> HotSpot Style Guide regarding C++17 features and their use in HotSpot code. >> >> Testing: mach5 tier1-8 >> >> This change includes a modification of the Style Guide. Rough consensus among >> the HotSpot Group members is required to make such a change. Only Group >> members should vote for approval (via the github PR), though reasoned >> objections or comments from anyone will be considered. A decision on this >> proposal will not be made before Friday 5-September-2025 at 12h00 UTC. >> >> Since we're piggybacking on github PRs here, please use the PR review process >> to approve (click on Review Changes > Approve), rather than sending a "vote: >> yes" email reply that would be normal for a CFV. > > Kim Barrett has updated the pull request incrementally with one additional > commit since the last revision: > > fix missing word doc/hotspot-style.md line 1333: > 1331: ### Enhanced selection statements > 1332: > 1333: C++17 modified the _condition_ part `if` and `switch` statements, > permitting Suggestion: C++17 modified the _condition_ part of `if` and `switch` statements, permitting doc/hotspot-style.md line 1367: > 1365: ``` > 1366: > 1367: C++17 also added compile-time if statements Suggestion: C++17 also added compile-time `if` statements ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26884#discussion_r2297265971 PR Review Comment: https://git.openjdk.org/jdk/pull/26884#discussion_r2297268021
