On Thu, 4 Sep 2025 14:03:41 GMT, Magnus Ihse Bursie <[email protected]> wrote:
> When calling ExecuteWithLog with a redirection (using > or, possibly, <), the > entire command needs to be executed in a subshell, that is, inside a pair of > parentheses. This is the callers obligation to ensure, but we have proven > multiple times that this is hard to keep in mind, and we got several cases of > race conditions due to missing this. > > This PR changes the implementation of ExecuteWithLog so it checks if the > command line contains redirection, and automatically add the subshell > parentheses in that case. The alternative would have been to always execute > in a subshell, but that would have been very expensive on Windows. I've tested our internal "builds" CI suite tier1-5. ------------- PR Comment: https://git.openjdk.org/jdk/pull/27096#issuecomment-3254251386
