On Tue, 9 Sep 2025 07:11:56 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use UTIL_ARG_ENABLE instead of AC_ARG_ENABLE > > make/autoconf/flags-cflags.m4 line 963: > >> 961: AC_MSG_RESULT([$sve_supported]) >> 962: $2SVE_CFLAGS="" >> 963: if test "x$enable_aarch64_sve" = "xyes"; then > > `UTIL_ARG_ENABLE` will return `true`, not `yes`. Have you even tested this > code? I did the test before. I was also confused that the `enable_aarch64_sve` sometimes return `yes`/`no`, sometimes return `true`/`false`, it seems depends the code implementations. The log snippet after run bash configure. > grep "enable_aarch64_sve=" build/linux-aarch64-server-release/configure.log -n 1117:+++ eval 'enable_aarch64_sve=$ac_optarg' 1118:++++ enable_aarch64_sve=yes 20015:+++ enable_aarch64_sve=true [configure.log](https://github.com/user-attachments/files/22246010/configure.log) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27073#discussion_r2335313423
