On Thu, 11 Sep 2025 21:13:57 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Create a seperate macro FLAGS_SETUP_SVE > > make/autoconf/flags-other.m4 line 140: > >> 138: ])], >> 139: [AVAILABLE=yes], >> 140: [AVAILABLE=no] > > The documentation of `UTIL_ARG_ENABLE` says that `AVAILABLE` needs to be set > to `false` when not available. Thanks for the advice. Updated. > make/autoconf/flags-other.m4 line 146: > >> 144: CFLAGS="$saved_cflags" >> 145: AC_LANG_POP([C]) >> 146: fi > > I think we need `AVAILABLE=fallse` when not matching the toolchain. This can > also be expressed as `AVAILABLE: false` as a parameter to `UTIL_ARG_ENABLE`. > The `CHECK_AVAILABLE` gets a chance to overwrite that value. Thanks for the advice. Updated. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27073#discussion_r2342866398 PR Review Comment: https://git.openjdk.org/jdk/pull/27073#discussion_r2342866074
