On Fri, 19 Sep 2025 16:43:50 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

> We currently have three macros (as in "functions", not just simple strings) 
> that are assigned in spec.gmk. This is in contrast with the rest of the 
> values assigned in spec.gmk, and it is surprising and is forcing an odd 
> syntax. Furthermore, these macros are named as constants, and not as we 
> normally name functions/macros.
> 
> We should move them to normal .gmk code, and rename them.
> 
> The three macros are `SET_SHARED_LIBRARY_ORIGIN`, `SET_EXECUTABLE_ORIGIN` and 
> `SET_SHARED_LIBRARY_NAME`.

This pull request has now been integrated.

Changeset: 3c6ef5e2
Author:    Magnus Ihse Bursie <i...@openjdk.org>
URL:       
https://git.openjdk.org/jdk/commit/3c6ef5e27ae3585b48e9599020e4323bf9ed381e
Stats:     109 lines in 8 files changed: 61 ins; 40 del; 8 mod

8368102: Don't store macros in spec.gmk

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/jdk/pull/27394

Reply via email to