On Tue, 23 Sep 2025 17:36:55 GMT, Erik Joelsson <[email protected]> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix comment and remove dead code > > make/common/CommonVars.gmk line 222: > >> 220: >> 221: # You run the new javac using the boot jdk with $(BOOT_JDK)/bin/java >> $(NEW_JAVAC) ... >> 222: # Use = assignment to be able to override in bootcycle-spec.gmk > > This comment isn't correct anymore. There were many issues here. First of all, NEW_JAVAC is not used anymore so it is dead code. Secondly, we still need = assignment for bootcycle builds, but only for JAVADOC. But this is not technically done in bootcycle-spec.gmk anymore. I removed the dead code and updated the comment, hope you are okay with it. There's a lot of cleaning work needed for this file. At this point, I just wanted to do a clear a separation as possible. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27452#discussion_r2376081463
