On Tue, 17 Dec 2024 14:54:03 GMT, Julian Waters <[email protected]> wrote:
>> This is a general cleanup and improvement of LTO, as well as a quick fix to >> remove a workaround in the Makefiles that disabled LTO for >> g1ParScanThreadState.cpp due to the old poisoning mechanism causing trouble. >> The -Wno-attribute-warning change here can be removed once Kim's new >> poisoning solution is integrated. >> >> - -fno-omit-frame-pointer is added to gcc to stop the linker from emitting >> code without the frame pointer >> - -flto is set to $(JOBS) instead of auto to better match what the user >> requested >> - -Gy is passed to the Microsoft compiler. This does not fully fix LTO under >> Microsoft, but prevents warnings about -LTCG:INCREMENTAL at least > > Julian Waters has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 12 additional > commits since the last revision: > > - Merge branch 'openjdk:master' into patch-16 > - -fno-omit-frame-pointer in JvmFeatures.gmk > - Revert compilerWarnings_gcc.hpp > - General LTO fixes JvmFeatures.gmk > - Revert DISABLE_POISONING_STOPGAP compilerWarnings_gcc.hpp > - Merge branch 'openjdk:master' into patch-16 > - Revert os.cpp > - Fix memory leak in jvmciEnv.cpp > - Stopgap fix in os.cpp > - Declaration fix in compilerWarnings_gcc.hpp > - ... and 2 more: https://git.openjdk.org/jdk/compare/7b66e192...9d05cb8e FWIW, I'm prototyping a possible change in g1ParScanThreadState.cpp that might substantially reduce the amount of generated code there. It might not work out; I haven't done any performance testing yet, and it's really easy to introduce performance regressions when making changes to that code. But if it does work, that might help with the problems here. ------------- PR Comment: https://git.openjdk.org/jdk/pull/22464#issuecomment-3426717092
