On Fri, 24 Oct 2025 07:22:40 GMT, Matthias Baesken <[email protected]> wrote:

>> When using stripped and not full pdb files on WIndows, the test 
>> CheckForProperDetailStackTrace.java misses source information (but this is 
>> not surprise with those much smaller pdb files; so probably we should not 
>> rely on having the source info available).
>> error output is :
>> 
>> 
>> java.lang.RuntimeException: Expected source information missing from output
>> at 
>> CheckForProperDetailStackTrace.main(CheckForProperDetailStackTrace.java:145)
>> at 
>> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
>> at java.base/java.lang.reflect.Method.invoke(Method.java:565)
>> at 
>> com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:335)
>> at java.base/java.lang.Thread.run(Thread.java:1474)
>
> Matthias Baesken has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Adjust style nit

This test is only run on debug builds. In the discussion in 
https://github.com/openjdk/jdk/pull/24012 it was pointed out that 
`--with-external-symbols-in-bundles=public` was an option meant for 
distribution builds and developers would opt out of it for a reasonable 
developer experience. Given that, I think this would be quite a rare 
combination. Especially without https://github.com/openjdk/jdk/pull/24012 since 
we are currently replacing the stripped PDB files in the image with the full 
ones anyway, for a local build-test, this test would work anyway. That said, I 
don't think this change hurts much either, given the rarity of the combination.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27899#issuecomment-3443241940

Reply via email to