On Sat, 8 Nov 2025 01:29:13 GMT, Dan Smith <[email protected]> wrote:

> Updated the JSpec taglets to use relative links into `../specs/jls` and 
> `../specs/jvms` rather than external links, possible now due to JDK-8370153.
> 
> I was surprised there doesn't seem to be a standard way to get a relative 
> path to the docs root, but I copy/pasted from ToolGuide, and made some tweaks 
> based on failures I saw.
> 
> Tested with 'make docs' and manually confirmed that a handful of different 
> `@jls` and `@jvms` tags are pointing to the right place.

Looks goood. Meanwhile, do you think we should retain external link support via 
a system property? For the Java SE API specification only distribution for JCP, 
we might want to link to a static link instead of a local relative link. (I 
think as long as we can link, a relative link like here is better because it 
will be stable in the specdiff for JCP review, avoiding spams)

Since we removed the system property jspec.version, we should be able to remove 
this from the build files too: 
https://github.com/openjdk/jdk/blob/066810c877b206a66cc87537487b17f0481646c3/make/Docs.gmk#L295

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28207#issuecomment-3505717390

Reply via email to