On Wed, 3 Dec 2025 15:50:00 GMT, Kurt Miller <[email protected]> wrote:
>> When building with external libpng the PNG defines added to CFLAGS may >> conflict with the installed libpng header pnglibconf.h resulting in >> compilation errors. For example on OpenBSD/aarch64: >> >> `/usr/local/include/pnglibconf.h:207:9: error: 'PNG_ARM_NEON_OPT' macro >> redefined [-Werror,-Wmacro-redefined]` >> >> This moves all `-DPNG_*` into the case where internal libpng is used. This >> has only been tested with the tier1 github actions so needs to be checked on >> Linux/ppc and AIX. > > Kurt Miller has updated the pull request incrementally with one additional > commit since the last revision: > > Clarify comment per code review @bsdkurt Your change (at version 50061a1d1a45ec56b9356eb78d93b6962cc43521) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk/pull/28324#issuecomment-3608563317
