On Sat, 10 Jan 2026 05:14:10 GMT, Jaikiran Pai <[email protected]> wrote:
> Can I please get a review of this jtreg failure handler code change which > addresses the issue noted in https://bugs.openjdk.org/browse/JDK-8374181? > > The implementation in this failure handler generates a cores.html for each > core file that was generated during the test run. The bug here is that > instead of creating multiple "sections", one each for the core file, within > an `<html>` element, it ends up creating multiple `<html>` elements one after > another within the same HTML file. This causes the HTML rendering to go wrong. > > The commit in this PR addresses that issue by creating one section, under the > `<html>` element, for each core file. > > I've verified that with this change, the cores.html is now correctly > structured and rendered. This pull request has now been integrated. Changeset: e89c1290 Author: Jaikiran Pai <[email protected]> URL: https://git.openjdk.org/jdk/commit/e89c1290ca8b3e07bef12f4c0465c3e83389fef4 Stats: 23 lines in 1 file changed: 12 ins; 1 del; 10 mod 8374181: failure_handler: The cores.html file is formatted incorrectly and so hides the core dump information Reviewed-by: erikj ------------- PR: https://git.openjdk.org/jdk/pull/29150
