On Mon, 19 Jan 2026 07:51:39 GMT, Aleksey Shipilev <[email protected]> wrote:

>> Julian Waters has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Remove -g and don't pass the flag at all if option is not given 
>> flags-cflags.m4
>
> make/autoconf/flags-cflags.m4 line 85:
> 
>> 83:     ],
>> 84:     IF_NOT_GIVEN: [
>> 85:       NATIVE_DEBUG_SYMBOLS_LEVEL=""
> 
> I would have thought this needs to be `-g`, so we pass `-g` when 
> `--native-debug-symbols-level` is not specified?

Good catch, I forgot about that, will revert.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29214#discussion_r2703668932

Reply via email to