On Tue, 20 Jan 2026 18:40:10 GMT, Kim Barrett <[email protected]> wrote:

> Please review this change to MacOSX and bsd code to avoid using literal zero
> as a null pointer constant, instead using nullptr.
> 
> Also disable that warning when building the gtest framework with clang,
> similarly to what was done in JDK-8338154 for gcc.
> 
> Testing: mach5 tier1.  Also tested with additional build changes to enable the
> warning.

Looks good.

If we don't already have the warning disabled, why are these occurrences not 
already causing warnings (and thus errors) in clang builds??

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/29329#pullrequestreview-3685377964

Reply via email to