On Tue, 3 Feb 2026 07:22:27 GMT, Kim Barrett <[email protected]> wrote:
> My feeling is the bad outweighs the good here. I don't think I like the idea > of having ghettos within HotSpot where different warning options are applied. After some discussion with Leo and others, I've decided I'm okay with the current iteration of this change. I think ghettoization would be bad, but that only happens if we let it. There seems to be a consensus that the intent is to use this for warnings we want to apply to all of HotSpot, but permit incremental expansion of the scope of such a warning until we're clean, then switch over to a HotSpot-wide warning (as provided by the infrastructure added by JDK-8332189). > I've not made any attempt to seriously review the new infrastructure here. > I'd prefer to leave that to people with a better understanding of makefile > programming and of our build system. I ended up looking at it after all, and to my somewhat untrained eye it seems okay. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29523#issuecomment-3947118477
