On Fri, 27 Feb 2026 14:48:05 GMT, Erik Joelsson <[email protected]> wrote:
>> GNU Make 4.4.1 changed the behavior of the variable MAKEFLAGS. This is >> causing our makefiles to behave weirdly in certain situations. We need to >> check for certain options in MAKEFLAGS to adjust behavior, and the way we do >> it is not compatible with GNU Make 4.4.1. In the GNU Make manual, it's >> [documented how you should query MAKEFLAGS for >> options](https://www.gnu.org/software/make/manual/make.html#Testing-Flags) >> and this patch is applying this recommendation. With this patch, I can >> successfully run the failing examples given in the bug using 4.4.1. I have >> also verified that tab completion still works and that the output of `make >> -p -q` looks the same before and after. >> >> Big thanks to Jaikiran who found the solution to this! > > Erik Joelsson has updated the pull request incrementally with one additional > commit since the last revision: > > Use MFLAGS The copyright year on this file will need an update before integrating. I built this latest state of PR and ran it on a Linux setup with both make 4.4.1 and the default make (which happens to be GNU Make 4.3 on that system). All the following three commands worked fine on both these versions of make and the build completed normally: make test TEST=test/jdk/java/text/ make test TEST=test/jdk/java/sql/ make test TEST=test/jdk/java/beans/PropertyChangeSupport/TestEquals.java So the change looks good to me. Thank you Erik for fixing this issue. ------------- Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/29942#pullrequestreview-3868034641 PR Comment: https://git.openjdk.org/jdk/pull/29942#issuecomment-3974031039
