On Thu, 5 Mar 2026 17:44:02 GMT, Kevin Walls <[email protected]> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix Lib.gmk for SA
>
> src/jdk.hotspot.agent/linux/native/libsaproc/symtab.c line 424:
>
>> 422: int st_type = ELF_ST_TYPE(syms->st_info);
>> 423: if (st_type != STT_FUNC && st_type != STT_OBJECT &&
>> 424: st_type != STT_NOTYPE && st_type != STT_NOTYPE) {
>
> Looks like duplication of st_type != STT_NOTYPE
> ah, so the symbol table read may have missed the trampoline method before.
__restore_rt is a FUNC, not sure if there are variations that are STT_NOTYPE so
we need this?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29731#discussion_r2891490385
