On Thu, 7 May 2026 23:33:08 GMT, Naoto Sato <[email protected]> wrote:

> Redoing the previously failed fix. The earlier fix unnecessarily added all 
> metazones to the root bundle, even when the names were empty. The revised fix 
> updates metazone names only when the mapped zone has its own names (which 
> fixes the original backporting issue, and is not applicable to the current 
> mainline). I confirmed that the resource bundles generated by CLDRConverter 
> are identical to those from the baseline build without this fix.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

IIUC, we are preventing the problem with the first version by ensuring 
metazones are not eagerly handled, such that metazones cannot be added if we 
are in the root case (`else if (id.equals("root"))`). This version still looks 
to be ensuring that the default 001 zone gets both its names and the metazone 
names, so looks OK to me.

-------------

Marked as reviewed by jlu (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/31084#pullrequestreview-4255953256

Reply via email to