On Thu, 21 May 2026 05:14:40 GMT, Jaikiran Pai <[email protected]> wrote:

>> Julian Waters has updated the pull request with a new target base due to a 
>> merge or a rebase. The incremental webrev excludes the unrelated changes 
>> brought in by the merge/rebase. The pull request contains two additional 
>> commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into awt
>>  - 8342869
>
> make/modules/java.base/Lib.gmk line 197:
> 
>> 195:       LINK_TYPE := C++, \
>> 196:       OPTIMIZATION := HIGH, \
>> 197:       CXXFLAGS := -std=c++17, \
> 
> Hello Julian, is this removal of `-std=c++17` an oversight?

Hi, to my knowledge C++17 is already used by the entire JDK, so I don't think 
this is needed anymore. Is there anything I've missed regarding simdsort that 
still needs this flag?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21655#discussion_r3278978294

Reply via email to