On Thu, 21 May 2026 18:30:16 GMT, Luigi Montoya <[email protected]> wrote:
>> As of the end of last year, Github Actions now supports Windows ARM64 >> runners. Also, we fixed all issues that would cause Windows ARM64 GHA tests >> to fail. >> >> This change includes: >> - Change Github Actions to natively build Windows ARM64. >> - Enable Github Actions testing for Windows ARM64. >> >> I also confirmed that the new `windows-11-arm` pool uses Visual Studio >> Enterprise 2022. For more information see >> [Windows11-Arm64-Readme](https://github.com/actions/runner-images/blob/main/images/windows/Windows11-Arm64-Readme.md#visual-studio-enterprise-2022) >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Luigi Montoya has updated the pull request incrementally with one additional > commit since the last revision: > > Split x64 and arm64 configurations All right, let's figure out the remaining nits and enable the tests. .github/actions/get-msys2/action.yml line 47: > 45: - name: 'Install MSYS2 on ARM64' > 46: id: msys2-arm64 > 47: uses: msys2/[email protected] Curious: is `2.31.0` that x86 uses not working / applicable to ARM64? .github/actions/get-msys2/action.yml line 51: > 49: install: 'autoconf tar unzip zip make' > 50: path-type: minimal > 51: release: true Does it work with `release: false`? AFAICS, this would let us reuse the MSYS2 installation, if any. Otherwise we would download MSYS2 every time. .github/workflows/main.yml line 464: > 462: bootjdk-platform: windows-aarch64 > 463: architecture: 'ARM64' > 464: runs-on: windows-11-arm This misses `dry-run: ${{ needs.prepare.outputs.dry-run == 'true' }}`, see the `test-windows-x64` definition above. make/conf/github-actions.conf line 52: > 50: > 51: WINDOWS_AARCH64_BOOT_JDK_EXT=zip > 52: > WINDOWS_AARCH64_BOOT_JDK_URL=https://github.com/adoptium/temurin26-binaries/releases/download/jdk-26%2B35-ea-beta/OpenJDK26U-jdk_aarch64_windows_hotspot_26_35-ea.zip This looks like `ea-beta` (pre-release) version. Is there a stable 26 release we can use? ------------- PR Review: https://git.openjdk.org/jdk/pull/31102#pullrequestreview-4344602023 PR Review Comment: https://git.openjdk.org/jdk/pull/31102#discussion_r3287674308 PR Review Comment: https://git.openjdk.org/jdk/pull/31102#discussion_r3287666352 PR Review Comment: https://git.openjdk.org/jdk/pull/31102#discussion_r3287655499 PR Review Comment: https://git.openjdk.org/jdk/pull/31102#discussion_r3287647207
