On Wed, 20 May 2026 09:20:55 GMT, Kevin Walls <[email protected]> wrote:

>> This implements "jcmd on core files" for Linux, and for MiniDumps on Windows 
>> (MacOS is "future work").
>> jcmd "revives" the VM memory and .so/.dll from the core/minidump, and runs 
>> the existing native diagnostic command parser and command implementations.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Kevin Walls has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   HotSpotAttachProvider back to only checking file exists

test/hotspot/jtreg/serviceability/revival/AttachRevival.java line 86:

> 84:             // Cause OOM:
> 85:             Object[] oa = new Object[Integer.MAX_VALUE / 2];
> 86:             for(int i = 0; i < oa.length; i++) {

Suggestion:

            for (int i = 0; i < oa.length; i++) {

test/hotspot/jtreg/serviceability/revival/JCmdRevival.java line 181:

> 179:         } else if (args[0].equals("oom")) {
> 180:             Object[] oa = new Object[Integer.MAX_VALUE / 2];
> 181:             for(int i = 0; i < oa.length; i++) {

Suggestion:

            for (int i = 0; i < oa.length; i++) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3306082805
PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3306084235

Reply via email to