On Fri, 5 Jun 2026 13:23:03 GMT, Erik Joelsson <[email protected]> wrote:

>> Yasumasa Suenaga has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Remove 32bit support from binutils build process
>
> make/devkit/Tools.gmk line 244:
> 
>> 242: ifeq ($(filter riscv64 ppc64le s390x armhfp, $(ARCH)), )
>> 243:   ENABLE_MULTILIB := --enable-multilib
>> 244: endif
> 
> @vidmik I'm curious about this one. Why do we need `--enable-multilib` here?

FWIW it's been there for quite a while, I just made it conditional on the 
`$ARCH` in my most recent change. If we remove 32-bit x86 support I think 
multilib effectively becomes dead code and should be removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31227#discussion_r3381999918

Reply via email to