> While following up on concurrent marking performance, I noticed that we 
> stopped / failed to inline some of the hot methods in marking loop. We need 
> to rework this.
> 
> This PR replaces the build-time "bump" for inlining heuristics into explicit 
> inlining hints across the hot path. I have eyeballed the profiles on typical 
> workloads and the inlining makes sense now.
> 
> Additional testing:
>  - [x] Linux x86_64 server fastdebug, `hotspot_gc_shenandoah`
>  - [x] Ad-hoc marking performance tests
>  - [ ] Regular testing pipelines
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Aleksey Shipilev has updated the pull request with a new target base due to a 
merge or a rebase. The incremental webrev excludes the unrelated changes 
brought in by the merge/rebase. The pull request contains seven additional 
commits since the last revision:

 - Keep "inline" on do_chunked_array
 - Merge branch 'master' into JDK-8385643-shenandoah-rework-mark-inline
 - Cosmetics
 - Benchmarks show array path is still important
 - A few more cosmetics
 - Touchup
 - Work

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/31634/files
  - new: https://git.openjdk.org/jdk/pull/31634/files/a57cb2fe..edb54f50

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=31634&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=31634&range=01-02

  Stats: 2772 lines in 112 files changed: 2252 ins; 188 del; 332 mod
  Patch: https://git.openjdk.org/jdk/pull/31634.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/31634/head:pull/31634

PR: https://git.openjdk.org/jdk/pull/31634

Reply via email to