On Sat, 27 Jun 2026 12:35:32 GMT, Jaikiran Pai <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2859 commits: >> >> - Merge branch '8317277' into jep401_sub_review_8317279 >> - Merge remote-tracking branch 'valhalla/lworld' into 8317277 >> - Merge >> >> Merge jdk-28+4 >> - 8386963: [lworld] Improve the exception message from Object >> synchronization methods on value objects >> >> Reviewed-by: dholmes, alanb >> - 8387300: [lworld] Minor review comments in javac >> >> Reviewed-by: vromero >> - 8387192: [lworld] Review comment drop for core libs >> >> Reviewed-by: jvernee, vromero >> - 8386999: [lworld] C2: assert(is_dead_loop_safe()) failed: shouldn't be >> cleared yet >> >> Reviewed-by: qamai, vlivanov >> - 8386787: [lworld] >> compiler/valhalla/inlinetypes/TestValueConstruction.java#StressIncrementalInliningDontInlineMyAbstractInit >> timed out >> >> Reviewed-by: phubner, chagedorn >> - 8386995: [lworld] Duplicate value classes are a preview feature warning >> >> Reviewed-by: alanb, vromero >> - 8383389: [lworld] Augment AOTMapLogger::print_oop_details to support flat >> arrays with oops >> >> Reviewed-by: iklam, fparain >> - ... and 2849 more: https://git.openjdk.org/jdk/compare/193de1b1...cdbe55a9 > > test/jdk/java/io/Serializable/valueObjects/SimpleValueGraphs.java line 79: > >> 77: @ParameterizedTest >> 78: @MethodSource("valueObjects") >> 79: public void roundTrip(Object expected) throws Exception { > > I think this test class and this test method in particular with need some > attention. The summary of this test says "Serialize and deserialize value > objects". This `roundTrip()` method sources its param from "valueObjects" > method. The `valueObjects()` method a few lines above constructs instances of > `SimpleValue` class. `SimpleValue` class (some lines below) is declared as: > > > public static class SimpleValue implements Serializable > > It's an identity class. So, unless I'm missing something, this test method > isn't testing anything related to value objects. I initially thought this > might be an oversight in the declaration of the `SimpleValue` class and it > probably was missing the `value` modifier. But this test method expects > instances of `SimpleValue` to be serialized and deserialized without any > exceptions, which is contrary to what is being proposed for value objects in > context of JEP-401. I've filed https://bugs.openjdk.org/browse/JDK-8387398 to track this. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3490880932
