On Tue, 30 Jun 2026 16:03:35 GMT, Joe Darcy <[email protected]> wrote:
>> src/java.base/share/classes/jdk/internal/util/ReferencedKeyMap.java line 52:
>>
>>> 50: * accomplished by using a backing map where the keys are either a
>>> 51: * {@link WeakReference} or a {@link SoftReference}.
>>> 52: * Keys must be {@linkplain Class#isIdentity() identity objects.}
>>
>> There is a typo here. `Class` doesn't have an `isIdentity()` method in this
>> version of the JEP implementation. I'll file an issue to fix it and to link
>> it to `Class.isValue()`.
>
> Hmm. There are build warning for javadoc link issues like that. If those
> warnings were disabled, they should be re-enabled before integration.
Hello Joe, this `jdk.internal.util.ReferencedKeyMap` is an internal class of
`java.base` module, exported only to select modules. So I suspect these checks
aren't run against such classes during the build (I maybe wrong, I haven't
checked).
I've filed https://bugs.openjdk.org/browse/JDK-8387495 with a PR available for
review https://github.com/openjdk/valhalla/pull/2603
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3500284387
