On Thu, 9 Jul 2026 15:05:44 GMT, Aleksey Shipilev <[email protected]> wrote:

>> Andrew Haley has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   More
>
> src/hotspot/cpu/aarch64/assembler_aarch64.hpp line 153:
> 
>> 151: 
>> 152: // State for randomized profile counters. Used by C1.
>> 153: extern Register r_profile_rng;
> 
> So if it is C1-only, should it _be_ in C1-specific assembler somewhere? Or we 
> would not be able to reference it from any shared code that is used by C1?

It's the only place it really works. c1_MacroAssembler.hpp can only declare 
`MacroAssembler` fields. Interpreter-only variables are declared here too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28541#discussion_r3559135733

Reply via email to