On Mon, 3 Aug 2026 14:18:34 GMT, Christoph Langer <[email protected]> wrote:
>> Currently we have a configure flag (--disable-cds-archive-nocoh) to disable >> cds archive creation for NOCOH (no compact object headers). >> Provide a similar configure flags to disable cds archive creation for >> NOCOOPS (no compressed oops; --disable-cds-archive-nocoops) and the new >> _preview jsa files (--disable-cds-archive-preview ) . >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > make/autoconf/configure.ac line 265: > >> 263: JDKOPT_ENABLE_DISABLE_CDS_ARCHIVE_NOCOH >> 264: JDKOPT_ENABLE_DISABLE_CDS_ARCHIVE_PREVIEW >> 265: JDKOPT_ENABLE_DISABLE_CDS_ARCHIVE_NOCOOPS > > please exchange these parameters for better alphabetical sorting. Makes sense! > make/autoconf/jdk-options.m4 line 827: > >> 825: UTIL_ARG_ENABLE(NAME: cds-archive-preview, DEFAULT: true, RESULT: >> BUILD_CDS_ARCHIVE_PREVIEW, >> 826: DESC: [enable generation of preview CDS archives (requires >> --enable-cds-archive)], >> 827: DEFAULT_DESC: [enable generation of preview CDS archives], > > remove the DEFAULT_DESC option, then the default description should be > "enabled", which makes more sense than `enable generation of preview CDS > archives` Okay! > make/autoconf/spec.gmk.template line 376: > >> 374: BUILD_CDS_ARCHIVE_NOCOH := @BUILD_CDS_ARCHIVE_NOCOH@ >> 375: BUILD_CDS_ARCHIVE_PREVIEW := @BUILD_CDS_ARCHIVE_PREVIEW@ >> 376: BUILD_CDS_ARCHIVE_NOCOOPS := @BUILD_CDS_ARCHIVE_NOCOOPS@ > > Same here, switch for sorting. Makes sense! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32174#discussion_r3710318512 PR Review Comment: https://git.openjdk.org/jdk/pull/32174#discussion_r3710325364 PR Review Comment: https://git.openjdk.org/jdk/pull/32174#discussion_r3710334226
