On Fri, 14 Aug 2026 19:22:10 GMT, Erik Joelsson <[email protected]> wrote:
>> Vladimir Ivanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8368597 make should support selection by status for JTREG tests > > make/RunTests.gmk line 1061: > >> 1059: $$(RM) -r $$($1_TEST_SUPPORT_DIR) >> 1060: $$(RM) -r $$($1_TEST_RESULTS_DIR) >> 1061: endif > > I think this is ok, but as I'm a very rare user of this myself, I would like > more inputs on if this could backfire in any way. > > Stylewise when mixing make conditionals and recipes we align and indent them > together, but with spaces for the make conditionals. So in this case, 8 > spaces for the `ifeq` and `endif` and tab+2spaces for the recipe lines inside > the block. > > Suggestion: > > ifeq ($(JTREG_STATUS),) > $$(call LogWarn, Clean up dirs for $1) > $$(RM) -r $$($1_TEST_SUPPORT_DIR) > $$(RM) -r $$($1_TEST_RESULTS_DIR) > endif Thanks, style was updated. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32377#discussion_r3786913600
