On Thu, 27 Aug 2026 10:57:25 GMT, Tobias Hartmann <[email protected]> wrote:
>> Boris Ulasevich has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains four commits:
>>
>> - C1: emit array access and acmp type profiles only when such profiling is
>> enabled
>> - allocate gap_bytes: move out of condition
>> - Use CHECK_AVAILABLE to explain why cds-archive-preview is unavailable
>> - 8390159: [ARM32] Native ARM32 build hangs in COMPILE_CREATE_SYMBOLS
>
> src/hotspot/share/c1/c1_GraphBuilder.cpp line 1393:
>
>> 1391: }
>> 1392: if ((stream()->cur_bc() == Bytecodes::_if_acmpeq ||
>> stream()->cur_bc() == Bytecodes::_if_acmpne) &&
>> 1393: is_profiling() && profile_branches() &&
>> MethodData::profile_acmp()) {
>
> I think this should also go through `Compilation` and incorporate the
> `is_profiling() && profile_branches()` checks.
Thanks. I moved it into Compilation::profile_acmp(), which now incorporates
is_profiling() && profile_branches().
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32402#discussion_r3874876950
