Re: RFR: 8358959: RISC-V: Add Zalasr [v17]

[Gui Cao]

On Tue, 15 Sep 2026 15:58:08 GMT, Axel Boldt-Christmas <abold...@openjdk.org> 
wrote:

>> Gui Cao has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   RISC-V: Gate native AtomicAccess Zalasr dispatch on a post-validated flag
>
> src/hotspot/os_cpu/linux_riscv/atomicAccess_linux_riscv.hpp line 285:
> 
>> 283:   T operator()(const volatile T* p) const {
>> 284:     STATIC_ASSERT(byte_size == sizeof(T));
>> 285:     STATIC_ASSERT(byte_size == 1 || byte_size == 2 || byte_size == 4 || 
>> byte_size == 8);
> 
> Removal of the STATIC_ASSERT macro is in flight, JDK-8392412 (#32883). 
> 
> Suggestion:
> 
>     static_assert(byte_size == sizeof(T));
>     static_assert(byte_size == 1 || byte_size == 2 || byte_size == 4 || 
> byte_size == 8);

Fixed.

> src/hotspot/os_cpu/linux_riscv/atomicAccess_linux_riscv.hpp line 305:
> 
>> 303:   void operator()(volatile T* p, T v) const {
>> 304:     STATIC_ASSERT(byte_size == sizeof(T));
>> 305:     STATIC_ASSERT(byte_size == 1 || byte_size == 2 || byte_size == 4 || 
>> byte_size == 8);
> 
> Removal of the STATIC_ASSERT macro is in flight, JDK-8392412 (#32883).
> 
> Suggestion:
> 
>     static_assert(byte_size == sizeof(T));
>     static_assert(byte_size == 1 || byte_size == 2 || byte_size == 4 || 
> byte_size == 8);

Thanks for the review, Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32309#discussion_r4021808762
PR Review Comment: https://git.openjdk.org/jdk/pull/32309#discussion_r4021808443