On Wed, 16 Sep 2026 15:02:46 GMT, Gui Cao <[email protected]> wrote: >> src/hotspot/cpu/riscv/gc/z/z_riscv.ad line 164: >> >>> 162: guarantee($mem$$disp == 0, "impossible encoding"); >>> 163: z_store_barrier(masm, this, Address($mem$$Register), >>> $src$$Register, $tmp1$$Register, $tmp2$$Register, false /* is_atomic */); >>> 164: __ sd_rl($tmp1$$Register, $mem$$Register); >> >> Same as above. May use `sd_release` or assert `UseZalasr` is always true. > > The predicate here already guards this — `needs_releasing_store(n)` returns > false whenever `!UseZalasr`, so this instruct only matches when `UseZalasr` > is true. No need for an extra assert.
Ohh, you are right. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32309#discussion_r4027982406
