On Fri, 9 Oct 2026 10:50:52 GMT, Dingli Zhang <[email protected]> wrote:

> Hi, please consider.
> 
> Building hsdis with binutils 2.47 fails because bfd.h no longer defines the 
> legacy `FALSE` macro. `init_disassemble_info_from_bfd()` in 
> `src/utils/hsdis/binutils/hsdis-binutils.c` still uses `FALSE` when setting 
> disassembler_needs_relocs, causing error: 'FALSE' undeclared.
> 
> Replace `FALSE` with the standard C boolean false. The file already includes 
> `<stdbool.h>` and uses false elsewhere, so this also preserves compatibility 
> with older binutils versions.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Thanks all for the review!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/33282#issuecomment-6094183819

Reply via email to