On Fri, 9 Oct 2026 18:48:29 GMT, Phil Race <[email protected]> wrote:

>>> Seems we can get rid of the 2 dummy-variables; no issues in our CI or in 
>>> GHA. Could maybe someone from Oracle (@prrace ?) test it in the Oracle CI?
>>> 
>>> I am bit surprised that I can just remove the dummy-variables; was it 
>>> something we needed back then for old compilers ?
>> 
>> I was a bit surprised too. I submitted a full product build + test job 
>> yesterday .. everything passd.
>> Although thinking about it I should submit a debug build too.
>
>> > Seems we can get rid of the 2 dummy-variables; no issues in our CI or in 
>> > GHA. Could maybe someone from Oracle (@prrace ?) test it in the Oracle CI?
>> > I am bit surprised that I can just remove the dummy-variables; was it 
>> > something we needed back then for old compilers ?
>> 
>> I was a bit surprised too. I submitted a full product build + test job 
>> yesterday .. everything passd. Although thinking about it I should submit a 
>> debug build too.
> 
> They passed.

Hi @prrace , thanks for the review!
@RealCLanger , @mrserb I need a second review on the last version/commit.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/33200#issuecomment-6119207868

Reply via email to