On Sun, 11 Oct 2026 06:15:10 GMT, Yunbo Zhang <[email protected]> wrote:

> Please review this small build fix.
> 
> `configure` reports `default` instead of `musl` for targets ending in 
> `linux-musleabi` or `linux-musleabihf`.
> 
> **Fix:**
> 
> `PLATFORM_EXTRACT_VARS_FROM_LIBC` now uses `*linux*-musl*` instead of 
> `*linux*-musl` to accept the ABI suffix.
> 
> **Testing:**
> 
> - `make test-make`: passed.
> - Added libc detection coverage to the existing Autoconf tests (`linux-musl`, 
> `linux-musleabi`, `linux-musleabihf`, `linux-gnu`).
> - ARM32 musl cross-configure with an explicit 
> `--openjdk-target=armv7l-unknown-linux-musleabihf`: reported `musl` after the 
> fix.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Something is off here. Why doesn't `*linux*-gnueabihf` fail the same way? 
`PLATFORM_EXTRACT_VARS_FROM_ABI` handles it, but 
`PLATFORM_EXTRACT_VARS_FROM_LIBC` does not. It makes sense, since all this 
`eabi*` stuff is really `ABI`.

So, how do we get to passing `linux-musleabi*` to 
`PLATFORM_EXTRACT_VARS_FROM_LIBC`?

-------------

PR Review: https://git.openjdk.org/jdk/pull/33300#pullrequestreview-5488595309

Reply via email to