On Thu, 15 Oct 2026 22:34:31 GMT, Ashay Rane <[email protected]> wrote:

>> Ashay Rane has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Handle EXCEPTION_STACK_OVERFLOW when yellow zone is unguarded
>>   
>>   The previous code did not handle a corner case that arises when HotSpot
>>   receives `EXCEPTION_STACK_OVERFLOW` (since the guard page cannot be
>>   moved further down) while already processing a recoverable overflow.  In
>>   this case, the yellow and reserved zones are writable (as part of the
>>   recoverable overflow), so we retry the same instruction.  If the
>>   faulting probe reaches the red zone, we'll receive
>>   `EXCEPTION_ACCESS_VIOLATION`, which will be handled as an unrecoverable
>>   overflow.
>
> Dean, I've updated the text and my notes on the proposed implementation.  The 
> [link](https://gist.github.com/raneashay/82a0e2b32b3c051e92c5686bc0905743) is 
> still the same.
> 
> This implementation gets pretty close to your previous suggestion of 
> switching to `PAGE_NOACCESS` page protection for the fixed guard zone after 
> the first stack overflow, without as much of the complexity as one of my 
> previous implementations.
> 
> I'll clean up the code and post it in this PR soon, so you can see the full 
> set of changes.

Thanks @raneashay for not giving up on this project!  I was able to get a 
Windows machines to test on, but I'm currently busy with other priorities.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/32365#issuecomment-6203745148

Reply via email to