On Thu, 29 Oct 2026 10:10:32 GMT, Andrew Haley <[email protected]> wrote:
>> Ashay Rane has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Documentation updates >> >> - Include section numbers from ARM ISA document >> - Mark branch protection on Windows/ARM64 as supported > >> Since CI doesn't test with branch protection enabled > > We could fix that. I wouldn't be against, say, building and testing just the > Windows/AArch64 build with it enabled. This would mean that ROP-breaking > changes would be detected in CI. @theRealAph I went ahead and updated the CI build rules to pass "--enable-branch-protection" during the build and "-XX:UseBranchProtection=standard" during the tests for both Linux/AArch64 and Windows/ARM64. If this ends up being too onerous, I'll back out the change to enable branch protection in CI while leaving the support in HotSpot as it is. The CI failure seems unrelated to the change (something about git.openjdk.org rejecting wget's default user agent). ------------- PR Comment: https://git.openjdk.org/jdk/pull/33595#issuecomment-6807165798
