#367: buildbot sighup fails if a LockAccess object is used instead of a Lock
object for builder['locks']
----------------------+-----------------------------------------------------
Reporter: tolsen718 | Owner: ddunbar
Type: defect | Status: closed
Priority: major | Milestone: 0.7.12
Version: 0.7.9 | Resolution: fixed
Keywords: |
----------------------+-----------------------------------------------------
Changes (by ddunbar):
* status: assigned => closed
* resolution: => fixed
Comment:
This was fixed in commit e092d24fe9fdf4d01d2d9c8752c7036982973af1.
I tested with this configuration and verified that the locks worked both
before and after a reconfig:
{{{
db_lock = buildbot.locks.MasterLock("database", maxCount = 2)
c['builders'] = []
c['builders'].append({
'slavenames' : ['slave_A', 'slave_B'],
'name' : "builder_A",
'builddir' : "builder_A",
'factory' : test_factory(),
'locks' : [db_lock.access('exclusive')],
})
c['builders'].append({
'slavenames' : ['slave_A', 'slave_B'],
'name' : "builder_B",
'builddir' : "builder_B",
'factory' : test_factory(),
'locks' : [db_lock.access('exclusive')],
})
c['builders'].append({
'slavenames' : ['slave_A', 'slave_B'],
'name' : "builder_C",
'builddir' : "builder_C",
'factory' : test_factory(),
'locks' : [db_lock],
})
c['builders'].append({
'slavenames' : ['slave_A', 'slave_B'],
'name' : "builder_D",
'builddir' : "builder_D",
'factory' : test_factory(),
'locks' : [db_lock],
})
}}}
--
Ticket URL: <http://buildbot.net/trac/ticket/367#comment:7>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
_______________________________________________
Buildbot-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/buildbot-commits
