#898: AssertionErrors on reconfig
-------------------+--------------------------------------------------------
Reporter: catlee | Owner:
Type: defect | Status: new
Priority: minor | Milestone: undecided
Version: 0.8.0 | Keywords:
-------------------+--------------------------------------------------------
Comment(by catlee):
So, I think this is caused by the following order of events:
- reconfig triggers BuildMaster.loadConfig_Builders
- which calls BotMaster.setBuilders
- which starts by creating a DeferredList which calls
disownServiceParent() for all the current builders. This deferred's
callback is attached to the local _add function which adds all the new
builders back.
- between disownServiceParent() being called, and the _add callback being
called, BotMaster._get_processors can be called from a previously
scheduled event, and it still has the list of _old_ builders, some of
which are now disconnected.
- Builder.run is called for the old builders, and self.running is False
for some of them now
Solutions?
Does disownServiceParent need to be called asynchronously?
Does Builder.run need to assert that its running?
--
Ticket URL: <http://buildbot.net/trac/ticket/898#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
lucky parental unit. See the prize list and enter to win:
http://p.sf.net/sfu/thinkgeek-promo
_______________________________________________
Buildbot-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/buildbot-commits
