#1701: Handle failures from the old slave/new slave ping remote call
------------------------+---------------------------------------------------
Reporter: exarkun | Owner:
Type: enhancement | Status: new
Priority: major | Milestone: undecided
Version: 0.8.2 | Keywords:
------------------------+---------------------------------------------------
`BotMaster.getPerspective` keeps track of currently connected slaves, and
does a special dance when a new connection arrives for a slave which
already has a connection. It issues a remote call to the existing
connection to verify it is still up and then kicks the new connection.
One expected outcome of this is that the old connection will be recognized
as defunct and the remote call will fail.
It would be nicer on logs and adminstrators if the remote call (
sl.slave.callRemote("print", "master got a duplicate connection;
keeping this one")
) had an errback attached which checked for the lost connection failure
type and reported the event in a less scary way. The current behavior
logs an unhandled failure in the Deferred. Better would be to just log
that the bot failed the ping test and has been disconnected.
--
Ticket URL: <http://buildbot.net/trac/ticket/1701>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
------------------------------------------------------------------------------
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
_______________________________________________
Buildbot-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/buildbot-commits
