#1740: variable naming incorrect
------------------------+---------------------------------------------------
Reporter: dreamfly912 | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone: 0.8.3
Version: 0.8.2 | Keywords:
------------------------+---------------------------------------------------
{{{
def mergeWith(self, others):
"""Generate a SourceStamp for the merger of me and all the other
BuildRequests. This is called by a Build when it starts, to figure
out what its sourceStamp should be."""
# either we're all building the same thing (changes==None), or
we're
# all building changes (which can be merged)
changes = []
changes.extend(self.changes)
for req in others:
changes.extend(req.changes)
newsource = SourceStamp(branch=self.branch,
revision=self.revision,
patch=self.patch,
project=self.project,
repository=self.repository,
changes=changes)
}}}
I think the variable 'req' used here in the for loop should mean
'sourcestamp'.[[BR]]
Should it be changed to a name that makes sense?
--
Ticket URL: <http://buildbot.net/trac/ticket/1740>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________
Buildbot-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/buildbot-commits
