#1750: gitpoller.py don't take care of git clone exit status code
-------------------+-----------------------
Reporter: atomik | Owner:
Type: defect | Status: new
Priority: major | Milestone: undecided
Version: 0.8.3 | Keywords:
-------------------+-----------------------
Hello,
I'm finding that, in gitpoller.py (line 68), you don't take care of git
clone exit status.
{{{
def startService(self):
base.PollingChangeSource.startService(self)
if not os.path.exists(self.workdir):
log.msg('gitpoller: creating working dir %s' % self.workdir)
os.makedirs(self.workdir)
if not os.path.exists(self.workdir + r'/.git'):
log.msg('gitpoller: initializing working dir')
# RETURN CODE SHOULD BE CHECKED HERE:
os.system(self.gitbin + ' clone ' + self.repourl + ' ' +
self.workdir)
}}}
This cause that, if you don't have access to git server, or have dns
error, or have network error, and every other errors during git clone
command, you won't be able to troubleshoot what happened, '''the error
will be misleading, because it occurs on the next executed command'''.
--
Ticket URL: <http://trac.buildbot.net/ticket/1750>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and,
should the need arise, upgrade to a full multi-node Oracle RAC database
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Buildbot-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/buildbot-commits
