#1749: xp slave fails to kill child process after network disconnect
--------------------------+--------------------
Reporter: philippem | Owner:
Type: defect | Status: new
Priority: critical | Milestone: 0.8.+
Version: 0.8.3 | Resolution:
Keywords: windows, kill |
--------------------------+--------------------
Comment (by philippem):
this fix seems to be working well for me.
I'm not 100% sure of the "dummy kill" behaviour, I did not test it, and I
don't really understand how the timer works. Also, it runs "if it's not
posix" which is Windows and maybe other platforms too. (BeOs? VMS?
OS/360?)
{{{
c:\Python27\Lib\site-
packages\buildbot_slave-0.8.3-py2.7.egg\buildslave>diff -c runprocess.py~
runprocess.py
diff -c runprocess.py~ runprocess.py
*** runprocess.py~ Mon Jan 17 10:01:49 2011
--- runprocess.py Fri Feb 04 20:51:50 2011
***************
*** 753,758 ****
--- 753,767 ----
# probably no-such-process, maybe because there is no
process
# group
pass
+ else:
+ # windows?
+ if self.KILL == None:
+ log.msg("self.KILL==None, only pretending to kill
child")
+ else:
+ os.system("TASKKILL /F /PID %s /T" % self.process.pid)
+ log.msg("used TASKKILL /F PID /T to kill pid %s" %
self.process.pid)
+ hit = 1
+
if not hit:
try:
if self.KILL is None:
}}}
--
Ticket URL: <http://trac.buildbot.net/ticket/1749#comment:19>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
Buildbot-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/buildbot-commits
