#1888: revlink is dangerous
----------------------+-----------------------
Reporter: dabrahams | Owner:
Type: undecided | Status: new
Priority: major | Milestone: undecided
Version: 0.8.3p1 | Keywords:
----------------------+-----------------------
Apparently my {{{revlink}}} function can receive a revision of "??"; I
didn't realize that and used this function, assuming I was getting a
revision of the form SHA|#SHA or #SHA|SHA, because that's what I'm
supplying from my changesource
{{{
revlink=lambda revision, repo_url:
'https://hub.boostpro.com/projects/'
+boostpro_repo_to_project(repo_url)
+'/repository/revisions/'
+ (x for x in revision.split('|') if
x.startswith('#'))
.next()[1:]
}}}
The result was a nasty jinja traceback. I guess maybe you should wrap
this function for the user in something that makes it safer?
--
Ticket URL: <http://trac.buildbot.net/ticket/1888>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
Buildbot-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/buildbot-commits
