#2052: Apparent bug in WarningCountingShellCommand
----------------------+------------------------
Reporter: dabrahams | Owner:
Type: defect | Status: closed
Priority: major | Milestone: undecided
Version: 0.8.4p1 | Resolution: fixed
Keywords: steps |
----------------------+------------------------
Changes (by Dustin J. Mitchell):
* status: new => closed
* resolution: => fixed
Comment:
Make all getProperties calls use the same signature
This fixes the remaining implementations of getProperty that still
raised KeyError (a la dict.__getitem__) instead of returning a default
value (a la dict.get): IBuildStatus (which was simply incorrect) and
BuildStep (which now uses PropertiesMixin).
All uses of getProperties are cleaned up to expect None on a missing
property, rather than KeyError.
Fixes #2052.
Changeset: 90da4d9b7b2f0e0a77a9d61ca845bf98cac128a1
--
Ticket URL: <http://trac.buildbot.net/ticket/2052#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
------------------------------------------------------------------------------
AppSumo Presents a FREE Video for the SourceForge Community by Eric
Ries, the creator of the Lean Startup Methodology on "Lean Startup
Secrets Revealed." This video shows you how to validate your ideas,
optimize your ideas and identify your business strategy.
http://p.sf.net/sfu/appsumosfdev2dev
_______________________________________________
Buildbot-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/buildbot-commits
