#827: ChangeSources may produce changes containing non-ascii bytestrings
------------------------------+-----------------------
Reporter: dustin | Owner:
Type: defect | Status: reopened
Priority: critical | Milestone: 0.8.5
Version: 0.7.12 | Resolution:
Keywords: encoding database |
------------------------------+-----------------------
Comment (by dustin):
OK, I tried to make the following change to the tests to replicate this:
{{{
#!patch
diff --git a/master/buildbot/test/unit/test_changes_p4poller.py
b/master/buildbot/test/unit/test_changes_p4poller.py
index 100ce29..766aacf 100644
--- a/master/buildbot/test/unit/test_changes_p4poller.py
+++ b/master/buildbot/test/unit/test_changes_p4poller.py
@@ -33,10 +33,10 @@ third_p4changes = \
"""
change_4_log = \
-"""Change 4 by mpatel@testclient on 2006/04/13 21:55:39
+u"""Change 4 by mpatel@testclient on 2006/04/13 21:55:39
- short desc truncated because this is a long description.
-"""
+ short desc truncated because this is a long \N{SNOWMAN}.
+""".encode('utf8') # test decoding unicode
change_3_log = \
"""Change 3 by bob@testclient on 2006/04/13 21:51:39
}}}
and I couldn't replicate it. I don't have access to a perforce instance,
so I don't know exactly what the various pieces are, but this seems to be
the same kind of response that contains the \x93\x94 you're seeing. What
have I missed?
My plan to fix this is to add an encoding parameter to the P4Poller, and
decode the responses from 'p4' using that encoding. But I need to
replicate the error first.
--
Ticket URL: <http://trac.buildbot.net/ticket/827#comment:18>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
------------------------------------------------------------------------------
Get a FREE DOWNLOAD! and learn more about uberSVN rich system,
user administration capabilities and model configuration. Take
the hassle out of deploying and managing Subversion and the
tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2
_______________________________________________
Buildbot-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/buildbot-commits
