#2111: Triggerable sheduler does not inherit Blamelist or Changes from upstream
timed.Nightly scheduler
-----------------------+---------------------
Reporter: garmstrong | Owner:
Type: defect | Status: closed
Priority: major | Milestone: 0.8.6
Version: 0.8.5 | Resolution: fixed
Keywords: |
-----------------------+---------------------
Changes (by dustin):
* status: new => closed
* resolution: => fixed
Comment:
Ah, the bug is actually in sourcestamp.py. getAbsoluteSourceStamp
passes _ignoreChanges so that the revision, branch, etc. are not set
from the changes -- however, that is taken to mean that changes should
not be kept at all, which is incorrect.
{{{
#!patch
commit 4f60e25e1bb85b7b8853f83b3af68607f9190026
Author: Dustin J. Mitchell <[email protected]>
Date: Fri Jan 13 20:25:31 2012 -0600
set self.changes even with _ignoreChanges
diff --git a/master/buildbot/sourcestamp.py
b/master/buildbot/sourcestamp.py
index e7c3fb9..a81ef56 100644
--- a/master/buildbot/sourcestamp.py
+++ b/master/buildbot/sourcestamp.py
@@ -145,8 +145,9 @@ class SourceStamp(util.ComparableMixin,
styles.Versioned):
self.patch_info = patch_info
self.project = project or ''
self.repository = repository or ''
- if changes and not _ignoreChanges:
+ if changes:
self.changes = tuple(changes)
+ if changes and not _ignoreChanges:
# set branch and revision to most recent change
self.branch = changes[-1].branch
revision = changes[-1].revision
}}}
--
Ticket URL: <http://trac.buildbot.net/ticket/2111#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
Buildbot-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/buildbot-commits
