#2139: locks held by slaves are not released when slave goes missing
--------------------+---------------------
Reporter: dwlocks | Owner:
Type: defect | Status: closed
Priority: major | Milestone: 0.8.6
Version: 0.8.4p2 | Resolution: fixed
Keywords: |
--------------------+---------------------
Comment (by dwlocks):
That should be self.releaseLocks()
It's committed in dwlocks/buildbot-0.8.4
7d0212ff8ec3f6d17c95e4df8fff493e29634682
diff --git a/master/buildbot/buildslave.py b/master/buildbot/buildslave.py
index e71d338..495544f 100644
--- a/master/buildbot/buildslave.py
+++ b/master/buildbot/buildslave.py
@@ -407,7 +407,7 @@ class AbstractBuildSlave(pb.Avatar,
service.MultiService):
log.msg("BuildSlave.detached(%s)" % self.slavename)
self.botmaster.parent.status.slaveDisconnected(self.slavename)
self.stopKeepaliveTimer()
- self.release()
+ self.releaseLocks()
def disconnect(self):
"""Forcibly disconnect the slave.
--
Ticket URL: <http://trac.buildbot.net/ticket/2139#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
Buildbot-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/buildbot-commits
