#2246: buildbot.status.builder.BuilderStatus uses slow LRU implementation
---------------------+-----------------------
Reporter: szager | Owner:
Type: defect | Status: new
Priority: critical | Milestone: undecided
Version: 0.8.6 | Keywords:
---------------------+-----------------------
BuilderStatus uses a very simple LRU implementation for storing
BuildStatus objects. When profiling a very busy buildbot master, I found
that fully a third of the CPU cycles were spent in
BuildStatus.touchBuildCache(). That method features a linear-time lookup
and expensive list operations (remove and copy).
Is there any reason why BuilderStatus shouldn't use
buildbot.util.lru.AsyncLRUCache for this? If that sounds like a good
idea, I can submit a patch.
Thanks,
Stefan
--
Ticket URL: <http://trac.buildbot.net/ticket/2246>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
Buildbot-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/buildbot-commits
