#2365: got_revision isn't properly set to a dictionary when codebases are used.
-------------------------------------+--------------------
Reporter:  tom.prince                |       Owner:
    Type:  defect                    |      Status:  new
Priority:  blocker                   |   Milestone:  0.8.7
 Version:  0.8.6p1                   |  Resolution:
Keywords:  master-side-source-steps  |
-------------------------------------+--------------------

Comment (by pepsiman):

 I don't think things are as broken as your notes suggest.

 > getAbsoluteSourceStamp on SourceStamp sets cloned.revision to
 got_revision, which won't work if it's a dictionary

 ```getSourceStamps``` on ```BuildStatus``` doesn't call
 ```getAbsoluteSourceStamp``` with a dictionary.

 Adding an assert should be sufficient.

 > fix source steps to read-modify-write

 ```setProperty``` on ```Source``` does read-modify-write when codebases
 are in use.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2365#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Buildbot-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/buildbot-commits

Reply via email to