#708: Incorporate bzr_poller.py and add more docs
------------------------+--------------------
Reporter: dustin | Owner:
Type: enhancement | Status: new
Priority: major | Milestone: 0.8.+
Version: master | Resolution:
Keywords: bzr |
------------------------+--------------------
Comment (by dustin):
IANAL, but that's one of the reasons it's in contrib/ - we don't
distribute such stuff, even if it is tracked in our git repositories. So
technically we've avoided the problem.
I don't think this is worth over-analyzing. We need to make a good-faith
effort to re-implement. If that leaves a few passages looking similar,
that's probably OK. But consulting the old code for lessons on
performance is probably a step too far. Could you make some performance
measurements directly, and perhaps include a comment in the updated source
indicating the results?
As for hook vs. poller - by no means must you write both. However, as I
indicated in comment 9, hooks are much harder to test, because they tend
to assume they're run within a bzr environment, rather than in buildbot,
and the buildbot tests do not require that bzr be installed. I'd be
hesitant to put an untestable hook into the distribution, since it runs a
very real risk of bitrot (similar to what the early parts of this bug
show).
--
Ticket URL: <http://trac.buildbot.net/ticket/708#comment:11>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Buildbot-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/buildbot-commits
